Repository navigation
chore(deps): upgrade @octokit/graphql 9, TypeScript 7, Vitest 4 - #30
Merged
Merged
Conversation
Closes #29. @octokit/graphql 8.2.2 -> 9.0.4. The only breaking change in v9.0.0 is dropping Node 18; there is no API change. Verified against the live API that errors are still GraphqlResponseError extends Error with the server message embedded in .message — the shape isDuplicateNameError matches on: Request failed due to following response errors: - Could not resolve to a node with the global id of 'PVTIF_bogus' That was the risk #29 called out: the create_iteration_field adoption fallback matches error text, so a restructured error would have silently stopped recognising duplicates. It does not. typescript 5.9.3 -> 7.0.2. The native compiler no longer picks up @types through pnpm's symlinked node_modules/@types, so every Node global (process, Buffer, fs) failed to resolve. Fixed by declaring "types": ["node"] explicitly, which is what the config should have said anyway. vitest 3.2.7 -> 4.1.10. No changes needed. @types/node stays on ^22 deliberately — engines says node >=22, so the types should match the oldest supported runtime rather than the newest available. Build, typecheck and 64 tests pass; dist/ emit verified loadable and the published tarball is unchanged at 23 files. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
joaodotwork
added a commit
that referenced
this pull request
Aug 14, 2026
Ships the @octokit/graphql 9 upgrade from #30. The TypeScript 7 and Vitest 4 bumps in that PR are dev-only and do not reach users. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29.
All three majors held back during the v1.6.0 release, done together because they share a lockfile.
@octokit/graphql8.2.2 → 9.0.4The one #29 flagged as high risk — every tool calls through it, and
isDuplicateNameErrorinsrc/tools/iterations.tsmatches onerror.messagetext, so a restructured error would silently stop recognising duplicate-name failures and break thecreate_iteration_fieldadoption fallback.It doesn't. v9.0.0's only breaking change is dropping Node 18 — no API change at all. Verified against the live API rather than trusting mocks:
Same shape the error-matching depends on, and the same format the original #21/#22 reports showed. The Node 18 drop is moot here —
enginesalready says>=22.typescript5.9.3 → 7.0.2The only upgrade that needed a code change. TypeScript 7's native compiler no longer picks up
@typesthrough pnpm's symlinkednode_modules/@types, so every Node global failed to resolve:Fixed by declaring
"types": ["node"]intsconfig.json. That's explicit configuration rather than a workaround — it narrows ambient types to exactly what's intended, which is what the config should have said all along.vitest3.2.7 → 4.1.10No changes needed. 64/64 pass on v4.
@types/nodestays on ^22Deliberately not upgraded to 26.
enginesdeclaresnode >=22, so the types should track the oldest supported runtime — on 26 the Node 26-only APIs would typecheck clean and then fail at runtime for anyone on 22. Revisit when the minimum moves.Verification
pnpm run build,pnpm run typecheck,pnpm test— 64/64 greendist/emit from the new compiler smoke-tested as loadable ESM (iterations8 exports,milestones2)No version bump — 1.6.0 is already published and only
@octokit/graphqlships to users. Worth folding into the next release rather than cutting one for it.🤖 Generated with Claude Code