Replace fake player code with fakelib#170
Open
OgelGames wants to merge 1 commit intojoe7575:masterfrom
Open
Conversation
Owner
|
Why should I do that? |
Author
Better compatibility with other mods and less bugs, because the fake player is more accurate.
Less maintenance, because you will no longer need to maintain the fake player code. If you don't like the idea that's okay, I just wanted to make PRs to replace every fake player implementation I could find :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the fake player code with fakelib's fake player.
https://content.minetest.net/packages/OgelGames/fakelib/