Define experimental packet assembly attestation - #70
Merged
Merged
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Reviewer's GuideThis PR adds RFC-0010 and a separate experimental packet-assembly-attestation package: a closed schema and reproducible Ed25519/RFC 8785 fixture harness that verifies independently selected builder trust and exact construction provenance, while explicitly preserving the HACP v0.3-candidate package unchanged. Sequence diagram for packet assembly attestation verificationsequenceDiagram
participant Verifier
participant Harness
participant TrustContext
participant Packet
participant Sources
participant Artifacts
Verifier->>Harness: validateAttestation(attestation, verificationContext, validateSchema)
Harness->>Harness: validateSchema(attestation)
Harness->>Harness: digestClaim(attestation)
Harness->>TrustContext: Resolve trusted builder principal and key
TrustContext-->>Harness: Active principal, profile, Ed25519 public key
Harness->>Harness: verify(signature, canonicalClaimInput(attestation), publicKey)
Harness->>Packet: Resolve exact packet and compare packet digest
Packet-->>Harness: Packet identity, schema version, digest
Harness->>Sources: Resolve source revision and bytes
Sources-->>Harness: Revision and SHA-256 digest
Harness->>Artifacts: Resolve profile, tool, and runtime artifacts
Artifacts-->>Harness: Artifact identities and digests
Harness-->>Verifier: Valid or exact diagnostic code
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Owner
Author
|
@codex review |
PR Summary by QodoDefine experimental packet assembly attestation
AI Description
Diagram
High-Level Assessment
Files changed (20)
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Code Review by Qodo
1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dcaef16158
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
Author
|
@codex review agent-control fresh required Codex review request |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Owner
Author
|
PR review loop disposition:
This note records why the loop is not waiting indefinitely on this finding state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packet-assembly-attestationrecord familyExplicit boundaries
createdBystring is rejected as insufficient.Validation
npm run hacp:packet-assembly-attestation— 1 valid, 6 exact invalid cases; 5/5 testsnpm run hacp:v03-candidate— 43/43 tests; all 22 exact negative casesnpm run hacp:cli-bridge-examples— 8/8 filesagent-control doctor --jsonagent-control onboard doctor --repo joefeser/hacp --base main --jsongit diff --checkschemas/v0.3-candidate/Closes #69.
Summary by Sourcery
Introduce an experimental, independently verifiable packet assembly attestation family without modifying the HACP v0.3-candidate package.
New Features:
Enhancements:
Documentation:
Tests: