Repository navigation
Write output frame by frame and check the output is writable up front - #71
Merged
Merged
Conversation
save_video assembled an (N, H, W, 3) uint8 copy of the whole video (plus full-size float temporaries for float input) before writing. It now converts and writes one BGR frame at a time; the file is byte-identical. main() also rejects a read-only output directory before processing instead of failing after the whole run. Closes #68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68
save_videoconverts and writes one BGR frame at a time instead of building an(N, H, W, 3)copy first. That copy was 0.28 GB for face.mp4, plus full-size float temporaries for float input. The written file is byte-identical: I compared MD5s of old and newsave_videoon random float channels with NaN and out-of-range values.main()exits 1 withError: output directory is not writable: ...before loading, instead of failing after the whole run.