You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Tests: nothing checks that sound is actually recovered; add a synthetic vibrating-surface test with known ground truth #20
Severity: Medium. The current tests check shapes, finiteness and range. The smoke tests feed random-noise frames, where there is no signal to recover, so a change that broke recovery would still pass. That's how #13, #14 and #17 went unnoticed.
Weak or misleading tests
test_constant_input_silent asserts only shape and finiteness. It doesn't check that the output is silent.
test_passband_preserved asserts std > 0.01 on output that is normalised to [−1, 1], so it passes for any non-constant signal.
test_stopband_attenuated compares standard deviations of two outputs, each normalised to its own peak. It passes because of how the 200-sample edges behave, not because the filter works.
The input-validation tests pass a file dummy.avi that doesn't exist, so any run that exits non-zero passes, even for an unrelated reason.
Proposed ground-truth test
This generator was used in the audit. It makes exact sub-pixel motion via the Fourier shift theorem, so recovery can be scored against the known signal:
Severity: Medium. The current tests check shapes, finiteness and range. The smoke tests feed random-noise frames, where there is no signal to recover, so a change that broke recovery would still pass. That's how #13, #14 and #17 went unnoticed.
Weak or misleading tests
test_constant_input_silentasserts only shape and finiteness. It doesn't check that the output is silent.test_passband_preservedassertsstd > 0.01on output that is normalised to [−1, 1], so it passes for any non-constant signal.test_stopband_attenuatedcompares standard deviations of two outputs, each normalised to its own peak. It passes because of how the 200-sample edges behave, not because the filter works.dummy.avithat doesn't exist, so any run that exits non-zero passes, even for an unrelated reason.Proposed ground-truth test
This generator was used in the audit. It makes exact sub-pixel motion via the Fourier shift theorem, so recovery can be scored against the known signal:
Suggested assertions:
-fl 100: correlation ≥ 0.99 (currently 0.95, see Measuring phase against frame 0 wraps once the surface drifts; use frame-to-frame differences plus a cumulative sum #17).Keep the clips short (1100 frames × 128², about 30 s each on CPU; or 64² for CI speed) and mark them
@pytest.mark.slowif needed.