Repository navigation
[AI:codex] docs(library): add a curated searchable product guide library (TASK-B6B1278890774EF993D2EBC327862470-111) - #3101
Conversation
…ary (TASK-B6B1278890774EF993D2EBC327862470-111)
… notes (TASK-B6B1278890774EF993D2EBC327862470-111)
ef7985c to
d84f608
Compare
3f2833e to
25f18f9
Compare
Review: PR-3101 (round 1): request changesReviewed head
CI: only Findings
Recommendation: one small rework round covering all of the above. Recovery: |
…0774EF993D2EBC327862470-111) # Conflicts: # docs/showcase/index.html
…-B6B1278890774EF993D2EBC327862470-111)
Review: PR-3101 (round 1 at
|
| Acceptance criterion | Status | Evidence |
|---|---|---|
| ac565cae allowlist/classification | ✅ verified | docs/showcase/publication.json (6 guides, human/operator), README "Curated library and publication scope"; build refuses unknown categories. The six-guide scope is still awaiting advisor confirmation on the spec. |
| acaff5ca static pages + search index from tracked sources | ✅ verified | build.py render_outputs/render_library; git ls-files --error-unmatch source gate; comments stripped; test_search_keeps_punctuation_and_link_labels |
| ac955c5b links/anchors/assets/provenance, mobile, keyboard | ✅ verified (manual) | Reviewer audit: 0 broken href/src/anchor across 7 generated pages. Longest unbreakable body token ≤ 23 chars, pre{overflow:auto}, single-column library below 600px. Native form controls with role=status live region and empty state. |
| ac9c1de7 stable rebuild, no hand-edited copy | ✅ verified | test_clean_check_and_rebuild_are_stable, test_check_names_all_drift_and_never_writes; build.py --check exits 0 at head; wired into CI's fast static step |
| acac445d owner-private, no new CLI/API | ✅ verified | Diff touches only docs/showcase, one test, one CI step line; no deploy |
Local evidence: python3 -m unittest tests/test_showcase_build.py passed all 7 tests, and build.py --check exited 0 with a clean tree. This PR is stacked on a non-main base, so the only PR check that ran is merge-hold-gate. It is red because of the standing hold from the prior round.
Non-blocking findings:
- The refusal paths (untracked source, symlink, path escape, unknown category) have no tests.
- Link resolution has no automated check.
- Advisor confirmation of the publication scope is still open.
- Cosmetic: the library card always appends "…", and
--checkprints a traceback on an untracked output.
…890774EF993D2EBC327862470-111)
|
Final-round author update at Merged the final corrected predecessor and regenerated affected guide/library artifacts. No new slice-specific content edits; final approval/base-only attestation remains the advisor’s decision. All lower-stack fixes are included by ordinary merges; no rebases or force pushes. These are author checks, with no independent-review or hold-clearance authority. Validation: |
|
Included in PR-3103, which merged the approved stack 107-113 to main as one PR (advisor 11:35). |
A curated searchable library renders six explicitly selected product guides from tracked Markdown and publication.json. It provides audience filters, snippets, reset/empty states and source links; all selected links remain available without JavaScript. The source/output ownership instructions now identify the manifest and omit transient process notes. Broader publication remains an explicit advisor curation question; no hosted audience changes.
Validation at author head
e15d8a968c1b7eed5bc4d25aa7a121aed07bfe72:make check-ci-fastcompleted all 35 gates successfully at this exact head. Guide output was rebuilt from its source and shared template; this change adds no runtime authority or deployment behavior. Author checks provide no independent approval or merge-hold clearance. Advisor review and bottom-up integration remain required.