Skip to content

Fix headless skill invocation + false-success detection #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joesaunderson merged 1 commit into from
Jul 10, 2026
Merged

Fix headless skill invocation + false-success detection #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions bin/babysit-prs-worker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,11 @@ if [[ "$PERMISSION_MODE" == "bypassPermissions" ]]; then
log_warn "Running with bypassPermissions (operator opt-in): the approval gate is OFF."
permission_args=(--permission-mode bypassPermissions)
else
# Explicit allowlist, no settings files loaded. Anything unlisted is denied.
permission_args=(--permission-mode default --setting-sources "" \
# Explicit allowlist. Do NOT pass --setting-sources "": that disables skill
# discovery, and the sweep itself is a skill (/babysit-prs), so the run would
# no-op with "Unknown command". The allowlist still constrains tools; any
# rules in ~/.claude/settings.json also apply.
permission_args=(--permission-mode default \
--allowedTools "${BABYSIT_ALLOWED_TOOLS[@]}")
fi

Expand All @@ -73,20 +76,37 @@ else
fi

set +e
"${run_prefix[@]}" \
output="$("${run_prefix[@]}" \
claude --print \
--session-id "$SESSION_ID" \
"${permission_args[@]}" \
--output-format text \
"$PROMPT"
--output-format json \
"$PROMPT")"
exit_code=$?
set -e

if [[ $exit_code -eq 124 ]]; then
log_error "Sweep timed out after ${BABYSIT_RUN_TIMEOUT_SECONDS}s (session ${SESSION_ID})"
elif [[ $exit_code -ne 0 ]]; then
exit 124
fi

# claude --print exits 0 even when it did nothing (e.g. an unknown slash
# command), so success is judged from the JSON envelope, not the exit code.
is_error="$(jq -r '.is_error // true' <<<"$output" 2>/dev/null || echo true)"
subtype="$(jq -r '.subtype // "unknown"' <<<"$output" 2>/dev/null || echo unknown)"
result="$(jq -r '.result // ""' <<<"$output" 2>/dev/null || echo "")"

log_info "Sweep result: ${result}"

if [[ $exit_code -ne 0 ]]; then
log_error "Sweep failed with exit code ${exit_code} (resume: cd ${REPO_ROOT} && claude --resume ${SESSION_ID})"
exit "$exit_code"
elif [[ "$is_error" == "true" || "$subtype" != "success" ]]; then
log_error "Sweep did not complete cleanly (is_error=${is_error}, subtype=${subtype})."
exit 3
elif [[ "$result" == *"Unknown command"* || -z "$result" ]]; then
log_error "Sweep produced no result; the skill was likely not invoked."
exit 3
else
log_success "Sweep finished (session ${SESSION_ID})"
fi
exit "$exit_code"
Loading