fix: Windows ESM import for start script - #26
Open
janeinari wants to merge 1 commit into
Open
Conversation
Dynamic import() rejects absolute Windows paths (drive letters look like URL schemes). Convert with pathToFileURL so npm start works on Windows 11.
Author
|
Local npm run verify on Windows 11 fails 9 tests for platform reasons (POSIX mode bits, spawn('npm') vs npm.cmd, spawning .mjs as GROK_BIN, path separator in workspace watcher). Unrelated to the pathToFileURL start fix. Happy to help with Windows test hardening in a follow-up if useful... 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pathToFileURLbefore dynamicimport()inscripts/start.mjs.npm starton Windows where absolute paths likeE:\...are not valid ESM module specifiers (the drive letter is treated as a URL scheme).Test plan