fix(theme): honor fontFamily, remove non-functional config keys#1
Closed
johnkferguson wants to merge 1 commit into
Closed
fix(theme): honor fontFamily, remove non-functional config keys#1johnkferguson wants to merge 1 commit into
johnkferguson wants to merge 1 commit into
Conversation
- Drop primaryColor and fontSize from theme.conf, flake.nix, README. Both were declared but never read by any QML; setting them was a no-op. - Wire config.fontFamily into Main.qml via two derived properties with fallback to the bundled FontLoaders. - Set the default fontFamily to "Google Sans Flex Freeze" (the actual family name embedded in assets/fonts/FlexRounded-*.ttf).
Owner
Author
|
Closing — this was just for review. Merging directly into feat/customizations. Upstream PR: xCaptaiN09#11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
primaryColorandfontSizewere declared intheme.confand accepted by the flake but never read by any QML — setting them did nothing. Drop both.fontFamilyhad the same problem. Wireconfig.fontFamilyintoMain.qmlvia two derived properties (activeFontRegular,activeFontBold) that fall back to the bundled FontLoaders when unset.Set the default to
"Google Sans Flex Freeze"— the actual family name embedded inassets/fonts/FlexRounded-*.ttf. The old defaultFlexRoundedwas a string Qt could never resolve.Test plan
sddm-greeter-qt6 --test-mode --theme .— default renders identically (uses bundled font)fontFamily=JetBrains Monointheme.confand rerun — text switches font.override { fontFamily = "JetBrains Mono"; }— built theme.conf has the override applied.override { primaryColor = "..."; }— now fails at evaluation (was silently ignored before)