Add full melody ingestion, dual-staff companion scores, and embedded MusicXML standards - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the request to support melodies in addition to chord progressions. It extends
jazz-toolsto ingest, parse, analyze, and render full lead sheet melodies alongside Berklee voice-led guide tone (3rds & 7ths) companion scores.Key Additions & Enhancements
Melody Data Model:
MelodyNotemodel (Pitch,Octave,DurationBeats,BeatOffset,IsRest,Tie,Lyric) ininternal/jazz/model.go.Melody []MelodyNoteto eachTimedMeasure, withHasMelody()andMelodyNotesCount()helpers on*Tune.MusicXML Parser Multi-Part Melody Extraction:
internal/jazz/musicxml_read.goto automatically inspect multi-part and single-part MusicXML files.Dual-Staff Companion Score Generation (MusicXML & LilyPond PDF):
musicxml_write.go): When melody notes are present, generates a braced 2-part companion score:lilypond.go): When melody notes are present, engraves a dual-staff system (\new Staff with { instrumentName = "Melody" }+\new Staff with { instrumentName = "Guide Tones" }) with real-time harmonic device brackets and key center annotations.Curated & Embedded MusicXML Jazz Standards:
//go:embed standards_xml/*.musicxmlininternal/jazz/standards.go:SearchStandardsto prioritize standards with full melodies.Web Interface & API:
AnalyzeResponseto include melody metadata and note collections.web/src/components/ScoreViewer.tsxto display instrument part names and dual-staff lead sheets.🎵 Melodybadges across standard search results and header metadata.All unit and integration tests are passing.