Feat/log user queries - #15
Merged
Merged
Conversation
with_logging(answer_fn) wraps AnswerFn to append each incoming query to data/raw/queries.jsonl (UTC timestamp + text). Setup (mkdir, FileHandler) runs once at construction in the composition root, not per query. Real queries collected here feed T24 (V1 vs V2 eval without data leakage). Also fixes AnswerFn being redefined locally instead of imported from telegram_bot.py, where it already lives.
mypy was already a dev dependency with basic config but was never run. Adds ignore_missing_imports overrides for rank_bm25/fitz (no type stubs) and runs it as part of `make lint` alongside ruff. make run-bot pointed at researchos.infrastructure.bot.main, which doesn't exist; points at the real entry point, scripts/run_telegram_bot.py.
mypy flagged rrf_scores/docs_by_id as needing var-annotated hints since they start empty. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.