Fix/clean clone and message limit - #3
Merged
Merged
Conversation
…ixture test_extract_text_pdf read data/samples/sample_pdf.pdf directly, which is gitignored (*.pdf) and fails on a clean clone. Build a minimal valid PDF in memory with fitz instead, since _extract_text needs real extractable text to exercise the actual code path.
Telegram rejects messages over MessageLimit.MAX_TEXT_LENGTH. _split_message breaks on the last whitespace before the limit and _handle_message sends the resulting chunks in sequence. The restriction lives in the channel, not the engine, so only telegram_bot.py changes.
ingest_papers() already does all the work; the script only parses --query/--max-results/--collection, calls ensure_dirs(), and drives the coroutine with asyncio.run(). Was a TODO stub since V1 week 1-2.
…n bank ADR-004 documents the AnswerFn/RetrieveFn pattern: Callable type aliases for single-behavior dependencies instead of a Protocol or a strategy flag. CA-004 described the Telegram bot as "planned for V2" and referenced telegram.py/store=... — both stale now that the bot is implemented with the retrieve-injection pattern. CA-005 referenced a script filename that was never real (ingest_papers.py instead of ingest_documents.py).
…ring debt Replaces relative-week sections with calendar-date windows per version (V1 real through V6), matching the new plan. Marks T11-T16 done for the Telegram bot work and today's fixes. Logs a new debt item: ingestion_ service.py imports httpx/fitz/arxiv.py at module level, violating the application-depends-only-on-domain rule that rag_service.py already follows via RetrieveFn injection.
Legend arrow samples are floating edges (no source/target node), and mxGraph requires them to declare sourcePoint/targetPoint explicitly or draw.io silently fails to render the line. legend_edge emits those attributes so legend samples always show up.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.