Fix/ingestion pdf dir clean clone - #5
Merged
Merged
Conversation
… from disk _download_pdf assumed data/papers/ already existed, which is only true if ensure_dirs() ran first. It never does in a clean clone, so extract_text_pdf raised FileNotFoundError. mkdir(parents=True, exist_ok=True) before the write makes the service robust regardless of call order. test_extract_text_pdf still wrote through to the real data/papers/ even after the previous fix (only the PDF bytes were mocked, not the write target). Patches PAPERS_DIR to tmp_path so the test never touches the repo. Verified in a genuinely fresh clone this time, not just the working copy — T14 was marked done on 12/08 without that check and this exact bug slipped through.
T14 was checked off on 12/08 without verifying in a clean clone — it still failed. Corrected the note to record what actually happened and the real completion date. T17 (merge to main) happened today via PR#4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.