Repository navigation
fix(sync): capture upload metadata and payload together - #208
Merged
Merged
Conversation
- Fold content(for:includingExpired:) into content(for:); upload preparation no longer reselects content by id, so no caller passes true. - State in ARCHITECTURE.md what the captured-row invariant covers and what is still read separately. - Mention the coherent upload fix in the v0.10.0 release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
pendingUpload(id:)andpendingUploads()decode content withcontent(from:)on the row they selected, instead of looking it up again by id.content(for:includingExpired:)intocontent(for:). Behavior is unchanged: expired rows are still filtered.SyncLocalStore.swiftand do not interact.Follow-ups (not in this PR)
SyncLocalStoreprotocol.BlobStore.Testing
swift-format lint --stricton the touched files,check-version-syncandcheck-product-truth.Checklist
make formatandmake lintpassmake testpassesGenerated by Claude Code