Repository navigation
fix(release): ignore the Action major tag when finding the previous release - #57
Merged
Merged
Conversation
…elease The release job moves v1 onto every stable release commit, so git describe --tags returns v1 instead of v1.11.0 and update-changelog.bash rejects it as a non-semver previous tag, failing release-preflight. Match only vX.Y.Z tags in the script and in the changelog guard test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release blocker found while preparing 1.11.1. Since v1.11.0 the release job moves the Action's major tag
v1onto the release commit, sogit describe --tags --abbrev=0returnsv1andscripts/update-changelog.bashrefuses it:release-preflightruns exactly that check, so the next manual release would fail before any mutation.Tag discovery now uses
--match 'v[0-9]*.[0-9]*.[0-9]*'in the script and in thetests/changelog.bashUnreleased guard (which was silently comparing againstv1).Tests
test_previous_tag_skips_major_alias: a temp repo withv1.0.0andv1on the same commit must producecompare/v1.0.0...v1.1.0. It fails onmainwith the error above.bash scripts/update-changelog.bash --check 1.11.1passes on this branch.scripts/validate-local.bashpasses locally on macOS.