Repository navigation
fix(deps): patch open dependency advisories across all lockfiles - #248
Merged
Merged
Conversation
- Raise the root brace-expansion floors to 1.1.21, 2.1.7 and 5.0.12 and fast-uri to 3.1.8, and add sharp 0.35.5 and smol-toml 1.9.0 floors, mirrored in package.json. - Pin sharp 0.35.5 in the license-server and update-server Workers, whose wrangler chain pinned 0.35.4, and raise the website fast-uri floor with npm 11. - No sprintf-js release fixes GHSA-hp3w-g68c-fv3c, and the Lua runner reaches it through fengari string.format. Patch 1.1.3 to clamp precision to the Number method ranges, so %.0g formats like C Lua instead of failing the run. - Cover the Lua precision cases in the runner tests; the case fails against the unpatched package. Changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Patches every open Dependabot advisory on
mainacross the four independently locked graphs.^1.1.21,^2.1.7,^5.0.12^0.35.5root, exact0.35.5in each Worker^1.9.0^3.1.8in bothsprintf-js reaches users. The Lua runner lazy-loads fengari in the renderer, and Lua's
string.formathands the format tosprintf. fengari caps width and precision at two digits, so oversized precisions cannot reach it. But%.0gpasses the scanner, and sprintf-js callstoPrecision(0), which throwsRangeError. fengari's protected call contains it, so the run fails with a meaningless error where C Lua prints2. The patch clamps precision to theNumbermethod ranges, with 1 as the%gminimum, matching C. The rest of the graph changes are dev-only.Root overrides live in
pnpm-workspace.yaml, mirrored inpackage.json. The Workers keep their exact-pin convention. The website lock was regenerated with npm 11.Validation
pnpm audit: only sprintf-js remains, by version; it is patched in place.npm audit: 0 vulnerabilities.check:prod-auditandcheck:bundled-audit: ok.pnpm why.vitest run, 824 files, 9306 tests. The new Lua case fails against the unpatched package.tsc --noEmit,typecheck:tests,lint,check:i18n,changelog:check,check:deadcode,check:deadcode:config(with website and Workers installed, as in CI), and websitenpm test(55): all green.tsc.pnpm run package:desktop: electron-builder packaged the macOS arm64 app; CI only builds bundles. The packaged renderer's fengari chunk contains the clamped precision.Follow-up