Repository navigation
fix(capsules): report engine divergence before baseline shape - #251
Merged
Merged
Conversation
- A real Python, Go or web Ruby recording carries per-line results, so capsule verify refused it as unsupported-baseline-output and never named the actual reason: its engine differs from the CLI runtime, so no baseline shape could make it comparable. - Check engine divergence first in capsuleStrictVerificationRefusal; the regression-suite export dialog shares the function and now shows its engine message for these recordings. - The verdict and exit code are unchanged (inconclusive, exit 6); only the reported reason changes. Browser preview keeps its position and exit 3. - Cover a real-shaped Python web recording, with line results and with a failed status, in the CLI and dialog tests. Changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lingua capsule verifyrefuses Python, Go and web Ruby recordings because their app engine (Pyodide, Go WASM, Ruby WASM) differs from the CLI runtime. But the baseline-shape checks ran first, and a real recording from the app always carries per-line results and rich outputs. So every real Python capsule was refused asunsupported-baseline-output("cannot supply a complete successful stdout/stderr baseline"), and the actual reason never appeared.Found while preparing the 1.6.0 announcement: a Python capsule exported from production
app.linguacode.dev1.6.0 (print("sum =", total)) never showed the engine message.This PR checks engine divergence first in
capsuleStrictVerificationRefusal. The regression-suite export dialog uses the same function, so it now shows its existing engine message instead of the generic "incomplete" one.inconclusive, exit 6. Onlyreason/detailchange for these recordings.Validation
dist/cli/lingua.cjs→error[engine-divergent-baseline], exit 6 (JSONreason: "engine-divergent-baseline");@linguacode/cli@1.6.0→error[unsupported-baseline-output], exit 6;tsc --noEmit,typecheck:tests,lint,check:i18n,check:i18n:copy,changelog:check;tests/cli,tests/shared,tests/components/CapsuleList,tests/renderer: 151 files, 2421 tests passed.dev:webcannot run, and no copy changed.