Repository navigation
ci: run the packaged macOS desktop smoke on pull requests - #252
Merged
Merged
Conversation
- The release job was the only place the packaged app smoke ran, so a renderer-gate regression from October 1 surfaced only after signing and notarization. - The macOS desktop-bundles PR job now packages an ad-hoc signed --dir app from the bundles it already built and runs smoke:desktop:packaged against it, uploading the smoke artifacts. - Raise the job timeout to 25 minutes for the extra packaging step and document the new gate in ARCHITECTURE.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The packaged-app smoke only ran inside the Release workflow, after signing and notarization. The October 1 renderer-gate regression (fixed in #249) therefore stayed invisible until the v1.6.0 release job hung for six minutes.
The macOS leg of
desktop-bundlesalready builds the desktop bundles on every PR. It now also:--dirapp (electron-builder --mac --dir -c.mac.identity=-, no secrets, no notarization);pnpm run smoke:desktop:packagedagainst it (LINGUA_SMOKE_TIMEOUT_MS=240000; it normally finishes in ~15 s);output/playwright/desktop-smokeasmacos-packaged-smoke-pr.The job timeout goes from 15 to 25 minutes.
docs/ARCHITECTURE.mddocuments the gate. Signing, notarization and updater manifests stay release-only.Validation
actionlint .github/workflows/ci.ymlclean;tests/docs+ website smoke workflow tests: 198 passed.--dirbuild, thensmoke:desktop:packaged→Cases: 3, failures: 0).ci.yml, so the new steps run on this PR itself; their result is the end-to-end proof.