Repository navigation
test(main): stop gitSecurity fixtures flaking on Windows runners - #256
Merged
Merged
Conversation
- Each fixture git call was killed after 5 s; a cold git on a hosted Windows runner exceeded that during the fixture commit, and the half-finished repository then failed cleanup with EPERM. - Bound git calls at 30 s, give this file's hooks and tests 60 s for their several git calls, and retry temporary-directory removal as the Windows install test already does. Changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows platform hardeningfailed once on #255 intests/main/gitSecurity.test.tsand passed on rerun:git commit -m fixtureinbeforeEachhit the helper's 5 sexecFileSynctimeout (spawnSync git ETIMEDOUT);rmSyncwithEPERMinafterEach.A cold
giton a hosted Windows runner (new temp dir, antivirus scanning) can exceed 5 s per call. The change:vi.setConfig), becausebeforeEachalone makes five git calls and Vitest's default hook timeout is 10 s;maxRetries: 5, retryDelay: 200), the same patterndependencies.install.windows.test.tsuses.Production code is unchanged.
Validation
tests/main/gitSecurity.test.ts: 9 passed locally;typecheck:testsand lint clean.Windows platform hardeningjob on this PR runs the file on the runner where it flaked.