Repository navigation
fix(export): preserve concurrent outputs during publication - #266
Merged
Merged
Conversation
- Check no-overwrite image, sidecar, and batch report targets with lstat so a dangling symlink fails preflight as an existing output instead of a late write failure - Drop the duplicate sidecar error logging now that the shared writer logs and maps failures - Add regression tests and a changelog entry for publication-time no-clobber
johnny4young
marked this pull request as ready for review
October 9, 2026 21:16
johnny4young
added a commit
that referenced
this pull request
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-overwriteimage, sidecar, manifest, and skipped-report writes. Enforce exclusivity when each output is published, rather than relying on preflight.--no-overwritepreflight now checks image, sidecar, and batch report targets without following symlinks, so a dangling symlink is reported as an existing output before rendering instead of failing late with a generic write error.writeFailed.Validation
8084a05f0c25f965fbecf188ca1dc0b581bda715: CI run passed all jobs (Linux static checks, Sequoia 15 and Tahoe 26 native build/test lanes, both UI lanes, GitGuardian).make lintsub-check andmake changelog-checkpassed;swift-format lint --strictandswiftc -parsepassed on the changed Swift files.Scope and limits
writeFailedrather thanoutputExists(same exit code); a late skipped-report failure stops before the manifest is written; a batch input whose image published but whose sidecar collided is reported as skipped without a manifest entry; the fallback re-stages the payload on every write to volumes without exclusive rename.Generated by Claude Code