Repository navigation
Conversation
- setup.py: pass the numpy include dir to every extension explicitly; CPATH is only honored by GCC/Clang, not by MSVC. - intset.pyx: drop the redundant typing annotations on IntSet.from_list / from_set, which Cython 3.3 rejects as conflicting signatures (the build currently fails with the unpinned Cython). - CI: add a windows-latest job that compiles the package, runs the test suite and builds AMD64 wheels with cibuildwheel for the same Python versions as the manylinux build; run on pull requests; scope the concurrency group per ref. - Publish all pyjpt-wheel-* artifacts (Linux and Windows). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tomsch420
force-pushed
the
windows-wheels
branch
from
November 20, 2026 12:17
697041f to
8e767bd
Compare
…as 3 - c45.py: allocate the shared index buffer as c_int64 instead of c_long. It is read back as np.int64, but C long is 32 bits on Windows. - c45.py: make the training data writable and C-contiguous with np.require. Under pandas 3, DataFrame.values can be read-only; the Cython impurity then raised in a worker and the pool hung forever. - CI: constrain pandas<3 and plotly<6.1 for the test install until the pandas 3 str dtype and the kaleido>=1 requirement are supported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
C4.5 learning, preprocessing, likelihood inference and leaf rendering fill a module-level threading.local in the parent and let pool workers read it. That only works with the "fork" start method. Under "spawn" (Windows; macOS default) the workers start without that state, fail, and the pool never completes, so the test suite hung on Windows CI. Add multicore.workers_inherit_state() and use DummyPool (the existing multicore=0 path) when it is False. Verified on Linux by running the full suite with the start method forced to "spawn". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Run the suite verbosely with a faulthandler watchdog that dumps all thread stacks and exits after 20 minutes, cap the step at 30 minutes, and force the non-interactive Agg matplotlib backend. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- pyproject.toml: on Windows, install kaleido==0.1.0.post1 with the plotly extra. kaleido 0.2.x hangs indefinitely on Windows in write_image (seen as a 20 minute stall in test_pdf_grid_2_plotly on CI). - Plotting engines and Distribution.plot: default the output directory to tempfile.gettempdir() instead of '/tmp', which does not exist on Windows (the matplotlib save_plot does not create it, so five plot tests failed). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Windows (AMD64) wheels to the release, next to the existing manylinux wheels, and fixes the code paths that hung or failed on Windows.
CI on this PR passes on both Linux and Windows. On Windows the extensions compile with MSVC, all 1,047 tests pass (4 skipped), and cibuildwheel builds
pyjpt-…-cp311-cp311-win_amd64.whl, which passes an import check.Build
setup.py: passes the numpy include dir to every extension.CPATHis only honored by GCC/Clang, not MSVC.intset.pyx: drops redundant typing annotations onIntSet.from_list/from_set. Cython 3.3 rejects them as conflicting signatures, so the build onmaincurrently fails with the unpinned Cython.Windows runtime fixes
c45.pyindex buffer: allocated asc_int64instead ofc_long. It's read back asnp.int64, butlongis 32-bit on Windows.threading.localthat only fork-started workers inherit. Underspawn(Windows; macOS default) the workers fail and the pool hangs. Newmulticore.workers_inherit_state(); when it is false, these use the existing in-processDummyPool(the same pathmulticore=0takes). Windows therefore learns on a single core for now; realspawnsupport would need the state passed to the workers explicitly.plotlyextra installskaleido==0.1.0.post1on Windows. kaleido 0.2.x hangs indefinitely inwrite_imageon Windows.tempfile.gettempdir()instead of/tmp, which doesn't exist on Windows.pandas 3
c45.pytraining data: made writable and C-contiguous withnp.require. Under pandas 3,DataFrame.valuescan be read-only, and the Cython impurity code then made the C4.5 worker pool hang.CI
faulthandlerwatchdog), and builds AMD64 wheels with cibuildwheel for the samepython-versionsas the manylinux build. The Linux job is unchanged apart from its artifact name (pyjpt-wheel-linux).pyjpt-wheel-*artifacts.pandas<3andplotly<6.1. Package metadata is unchanged.Known issues on
main, not addressed herestrdtype (Unknown column type: … [str], about 50 test errors).kaleido>=1, while the extra pinskaleido<1.0.Not yet exercised
The publish workflow only runs on version tags, so collecting several artifacts in the publish step is untested until the next release. The release workflow passes
cp39–cp312to cibuildwheel; this PR's run only builtcp311.🤖 Generated with Claude Code