Declare audit_quotes in the attest_response input schema - #92
Open
karpovantonme wants to merge 1 commit into
Open
Declare audit_quotes in the attest_response input schema#92karpovantonme wants to merge 1 commit into
karpovantonme wants to merge 1 commit into
Conversation
The handler reads arguments.get('audit_quotes') and honours it, but the
schema did not declare it, so no MCP client could reach the quote audit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
attest_responsedeclaresdraft_textandaudit_groundingin its input schema. The handler reads a third argument:Adds
audit_quotesto the schema so a client can actually reach it.Why
_handle_attest_responsehonours the flag, and its docstring points callers at it: "Callers that still want the whole-document quote audit can passaudit_quotes=True." No MCP client can. The property is not in the schema, so a model never learns it exists, and the call succeeds either way while silently running with the default. The quote audit is unreachable over MCP today.Nothing in the handler changes; the description text is taken from the reasons already given in
_handle_attest_responsefor why it defaults to off.Checklist
make testpasses locally (offline, no live network in tests)docs/canonical_numbers.mdpublish.py, DB schemas,base_scraper.pyorstate/: it does nottests/test_attest_response_schema.pyfails on main and passes here.The
make testbox is unchecked on purpose: I ran the two files that touch this area, not the full suite.mcp 2.0breaks collection for your existing tests as well (AttributeError: 'Server' object has no attribute ...), so I pinnedmcp<2locally;requirements.txtcurrently saysmcp>=1.27.0with no upper bound, which may be worth a separate look.