refactor: shorten cluster/release names + fix ExternalSecret key fmt#10
Merged
Conversation
jonathandieu
commented
Jun 25, 2026
Owner
- Rename clusters/dieubernetes-platform-do-atl1 to clusters/platform-do-atl1 to match the ArgoCD cluster secret
- Set releaseName: "{{ .app }}" in the infrastructure AppSet so Helm releases use short names instead of the overly verbose full Application name, avoiding the 63-char label limit that was breaking the envoy-gateway certgen Job.
- Fix ExternalSecret remoteRef keys: onepasswordSDK expects item-uuid/field format, not plain item names or op:// URIs.
There was a problem hiding this comment.
Pull request overview
This PR updates the infrastructure deployment configuration to use shorter, more consistent cluster/release naming and aligns ExternalSecret remoteRef key formatting with the OnePassword SDK provider expectations.
Changes:
- Shorten the
platform-do-atl1cluster name to match the ArgoCD cluster secret naming. - Configure ArgoCD ApplicationSet Helm releases to use shorter release names.
- Update ExternalSecret
remoteRef.keyvalues to use the OnePassword SDKitem-id/fieldformat, and add cluster-specific overrides for metrics-server and envoy-gateway.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| clusters/platform-do-atl1/overrides/metrics-server.yaml | Adds a DOKS-specific metrics-server arg override to allow scraping kubelets with self-signed certs. |
| clusters/platform-do-atl1/overrides/envoy-gateway.yaml | Adds a per-cluster DigitalOcean load balancer adoption annotation for Envoy Gateway’s service. |
| clusters/platform-do-atl1/cluster.yaml | Renames the cluster to a shorter, ArgoCD-aligned name (platform-do-atl1). |
| charts/infrastructure/kube-prometheus-stack/templates/grafana-cloud-credentials.yaml | Updates OnePassword-backed ExternalSecret keys to item-id/field format for Grafana Cloud creds. |
| charts/infrastructure/external-dns/templates/cloudflare-token.yaml | Updates OnePassword-backed ExternalSecret key to item-id/field format for the Cloudflare token. |
| argocd/apps/infrastructure/appset.yaml | Sets a Helm releaseName for ApplicationSet-rendered infrastructure charts (shortening rendered resource names). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.