Skip to content

refactor: shorten cluster/release names + fix ExternalSecret key fmt#10

Merged
jonathandieu merged 1 commit into
mainfrom
refactor/cluster-names-eso-keys
Jun 25, 2026
Merged

refactor: shorten cluster/release names + fix ExternalSecret key fmt#10
jonathandieu merged 1 commit into
mainfrom
refactor/cluster-names-eso-keys

Conversation

@jonathandieu

Copy link
Copy Markdown
Owner
  • Rename clusters/dieubernetes-platform-do-atl1 to clusters/platform-do-atl1 to match the ArgoCD cluster secret
  • Set releaseName: "{{ .app }}" in the infrastructure AppSet so Helm releases use short names instead of the overly verbose full Application name, avoiding the 63-char label limit that was breaking the envoy-gateway certgen Job.
  • Fix ExternalSecret remoteRef keys: onepasswordSDK expects item-uuid/field format, not plain item names or op:// URIs.
image

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the infrastructure deployment configuration to use shorter, more consistent cluster/release naming and aligns ExternalSecret remoteRef key formatting with the OnePassword SDK provider expectations.

Changes:

  • Shorten the platform-do-atl1 cluster name to match the ArgoCD cluster secret naming.
  • Configure ArgoCD ApplicationSet Helm releases to use shorter release names.
  • Update ExternalSecret remoteRef.key values to use the OnePassword SDK item-id/field format, and add cluster-specific overrides for metrics-server and envoy-gateway.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
clusters/platform-do-atl1/overrides/metrics-server.yaml Adds a DOKS-specific metrics-server arg override to allow scraping kubelets with self-signed certs.
clusters/platform-do-atl1/overrides/envoy-gateway.yaml Adds a per-cluster DigitalOcean load balancer adoption annotation for Envoy Gateway’s service.
clusters/platform-do-atl1/cluster.yaml Renames the cluster to a shorter, ArgoCD-aligned name (platform-do-atl1).
charts/infrastructure/kube-prometheus-stack/templates/grafana-cloud-credentials.yaml Updates OnePassword-backed ExternalSecret keys to item-id/field format for Grafana Cloud creds.
charts/infrastructure/external-dns/templates/cloudflare-token.yaml Updates OnePassword-backed ExternalSecret key to item-id/field format for the Cloudflare token.
argocd/apps/infrastructure/appset.yaml Sets a Helm releaseName for ApplicationSet-rendered infrastructure charts (shortening rendered resource names).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread argocd/apps/infrastructure/appset.yaml
@jonathandieu jonathandieu merged commit f8da22c into main Jun 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants