fix(eso): update ESO API version from v1beta1 to v1#9
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates External Secrets Operator (ESO) custom resources in this repo to use the promoted external-secrets.io/v1 API so ArgoCD can successfully apply ClusterSecretStore and ExternalSecret manifests when the installed ESO no longer serves v1beta1.
Changes:
- Bump
ExternalSecretmanifests fromexternal-secrets.io/v1beta1toexternal-secrets.io/v1. - Bump
ClusterSecretStoremanifest fromexternal-secrets.io/v1beta1toexternal-secrets.io/v1. - Eliminates ArgoCD “resource mapping not found” failures caused by referencing the removed
v1beta1API.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/infrastructure/kube-prometheus-stack/templates/grafana-cloud-credentials.yaml | Switches ExternalSecret apiVersion to external-secrets.io/v1 for Grafana Cloud credentials. |
| charts/infrastructure/external-secrets/templates/cluster-secret-store.yaml | Switches ClusterSecretStore apiVersion to external-secrets.io/v1 for the onepassword store. |
| charts/infrastructure/external-dns/templates/cloudflare-token.yaml | Switches ExternalSecret apiVersion to external-secrets.io/v1 for Cloudflare token. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClusterSecretStore and ExternalSecret were promoted to v1 in ESO 0.9+.
The installed version no longer serves v1beta1, causing resource mapping failures during ArgoCD sync.