Skip to content

Initialize the full-mesh bsubs in jxbforce - #14

Open
CharlesCNorton wants to merge 1 commit into
jonathanschilling:masterfrom
CharlesCNorton:fix/jxbforce-bsubs-init
Open

Initialize the full-mesh bsubs in jxbforce#14
CharlesCNorton wants to merge 1 commit into
jonathanschilling:masterfrom
CharlesCNorton:fix/jxbforce-bsubs-init

Conversation

@CharlesCNorton

Copy link
Copy Markdown
Contributor

Fixes #8.

The local full-mesh bsubs in jxbforce is filled for js = 2..ns-1 only, but the radial loop reads row ns in its last pass (bs1=>bsubs(js,:) for lasym, bsubs_s(:) = bsubs(js,:) otherwise) and Fourier-transforms it. The array is now zeroed on entry.

Rows ns of bsubsu, bsubsv, bsubuv and bsubvu are never consumed, so the wout and jxbout files are unchanged bit for bit on input.cth_like_fixed_bdy in both symmetry modes. Built with -fcheck=all -finit-real=snan -ffpe-trap=invalid,zero,overflow, the runs that used to stop at jxbforce.f90:233 (symmetric) and fsym_fft.f90:52 (lasym) now terminate normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jxbforce reads uninitialized bsubs(ns,:) in the js = ns pass

1 participant