Initialize the full-mesh bsubs in jxbforce - #14
Open
CharlesCNorton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8.
The local full-mesh
bsubsin jxbforce is filled forjs = 2..ns-1only, but the radial loop reads rownsin its last pass (bs1=>bsubs(js,:)for lasym,bsubs_s(:) = bsubs(js,:)otherwise) and Fourier-transforms it. The array is now zeroed on entry.Rows
nsofbsubsu,bsubsv,bsubuvandbsubvuare never consumed, so the wout and jxbout files are unchanged bit for bit oninput.cth_like_fixed_bdyin both symmetry modes. Built with-fcheck=all -finit-real=snan -ffpe-trap=invalid,zero,overflow, the runs that used to stop at jxbforce.f90:233 (symmetric) and fsym_fft.f90:52 (lasym) now terminate normally.