Scan every toroidal plane for the axis guess of a lasym run - #24
Open
CharlesCNorton wants to merge 1 commit into
Open
Scan every toroidal plane for the axis guess of a lasym run#24CharlesCNorton wants to merge 1 commit into
CharlesCNorton wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21.
guess_axisalready computes the number of planes it has to scan,but the plane loop runs to
nzeta/2+1regardless, so forlasym = Tthe entriesrcom(nzeta/2+2:nzeta)andzcom(nzeta/2+2:nzeta)reach the axis Fourier transform unassigned. The loop now usesivmax, which is the same bound as before forlasym = Fand covers the whole toroidal range otherwise. PARVMECguess_axis.f:132scans allnzetaplanes for the same reason.Checked with
input.cmarun withLASYM = FandLASYM = T, the latter with every asymmetric coefficient left at zero. Both trigger the axis reguess. Before this change the asymmetric run stops withThe jacobian was non-definite!atns = 25; after it, both runs terminate normally atns = 51and their wout files agree to the 1e-6 force tolerance of the case.wout_cma.nc,wout_solovev.ncandwout_cth_like_fixed_bdy.ncare unchanged bit for bit, sinceivmaxisnzeta/2+1in the symmetric branch.VMEC++ carries the same half-range loop at
guess_magnetic_axis.cc:382, fixed in proximafusion/vmecpp#787.