refactor(ui): align TUI and web information colors - #1244
Merged
Merged
Conversation
Map working / needs-you / error / success / danger and user vs tool labels to the same roles on both surfaces. Selected rows use a purple rule plus highlight fill, not glow. Document the contract in docs/theme.md. Fixes #1237
jonathanung
commented
Aug 17, 2026
jonathanung
left a comment
jonathanung
left a comment
Owner
Author
There was a problem hiding this comment.
Review pass 1 on a2a313c
Verdict: approve (0 blocking, 0 should-fix)
Reviewed gh pr diff 1244 plus Status/App/theme CSS callers. Working / needs-you / error / success / danger / user / tool / selected now share roles; permission wins over busy on the header pulse; docs table present. No keybind or protocol changes.
Blocking
none
Should-fix
none
Nits
web/src/ui/Status.tsxliveStatusKind({ failed })and.pulse.failedare unused in App header. Web has no sessionErrored field; failed tools already use--signal. Deferred: no product signal to wire.Team.tsxStatusBadge kind=\"idle\"for read-only now inherits Success (ready). Pre-existing kind stretch; not a live-session chrome path.
Merge checklist may proceed for this SHA only.
Owner
Author
Review pass 1 (head
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentStateand webStatus/ pulse / tool rows use the same roles.--raisedfill and--highlighttext (no glow).docs/theme.md. Permission/question wins over busy on the web header pulse, matching TUIagentState.Issue
Fixes #1237
Tier
B
Verification
gofmton touched Gomake web-checkenv -u AWS_PAGER make test && make vet && make buildTestCollectForwardedEnvfails when hostAWS_PAGERis set; unrelated env leak, green afterenv -u AWS_PAGER