Skip to content

fix(web): scroll runtime bar instead of spilling the shell - #1248

Merged
jonathanung merged 1 commit into
mainfrom
worktree-1246-runtime-scroll
Aug 17, 2026
Merged

jonathanung merged 1 commit into
mainfrom
worktree-1246-runtime-scroll

Conversation

@jonathanung

Copy link
Copy Markdown
Owner

Summary

  • Expanding Runtime… now scrolls the config bar (overflow-x: auto) instead of growing .app-shell / main.
  • .runtime-stack gets min-width: 0; secondary fields keep min-content so the bar is the scrollport.
  • Regression tests at 900px and 360px: shell/main scrollWidth stays within clientWidth.

Issue

Fixes #1246

Tier

B

Verification

  • test -z "$(gofmt -l .)"
  • make web-check
  • make test && make vet && make build
  • smoke: skipped (web CSS/layout only; no cmd/engine/tui/session/auth)

Note: TestCollectForwardedEnv failed once locally when host AWS_PAGER= matched AWS_*; 3/3 pass with env -u AWS_PAGER. Unrelated env flake.

Copilot AI lite review requested due to automatic review settings August 17, 2026 02:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@jonathanung

Copy link
Copy Markdown
Owner Author

Review pass 1 (head c492a009438947a4766dcf5ae06152b37f787f8f) — clean

Verdict: approve (internal; COMMENT only)

0 blocking, 0 should-fix. Merge checklist may proceed for this SHA only.

Reviewed gh pr diff 1248 plus surrounding runtime CSS (.runtime-stack / .runtime / .runtime-more / .runtime-secondary) and the existing runtime op tests.

  • Expanding Runtime… stays inside .runtime (overflow-x: auto); stack is min-width: 0 so main / .app-shell do not grow.
  • Secondary fields use min-content / flex-shrink: 0 so the bar is the scrollport instead of leaking visible overflow.
  • CSS contract in styles.layout.test.ts; App test expands at 900px and 360px and checks containment. jsdom cannot measure real scrollWidth; metrics are modeled from those rules (acceptable for unit gate; e2e already has page-level overflow checks).

Nits (deferred)

  • App.test.tsx duplicates the CSS rule() helper already in styles.layout.test.ts.
  • Modeled scrollWidth will not catch a future override that keeps the same declarations but still expands the shell.

@jonathanung
jonathanung merged commit 7263dc7 into main Aug 17, 2026
3 checks passed
@jonathanung
jonathanung deleted the worktree-1246-runtime-scroll branch August 17, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(web): runtime config bar must scroll instead of spilling the shell

2 participants