Skip to content

[MRG] ENH: change 'Delete all drives' button color to red for better UX#1245

Merged
asoplata merged 7 commits intojonescompneurolab:masterfrom
m-ahmad-amin:m-ahmad-amin/delete-all-drives-button-color
Apr 1, 2026
Merged

[MRG] ENH: change 'Delete all drives' button color to red for better UX#1245
asoplata merged 7 commits intojonescompneurolab:masterfrom
m-ahmad-amin:m-ahmad-amin/delete-all-drives-button-color

Conversation

@m-ahmad-amin
Copy link
Copy Markdown
Contributor

@m-ahmad-amin m-ahmad-amin commented Feb 25, 2026

This PR updates the “Delete all drives” button in the HNN GUI to red, making its destructive action more visually noticeable. The change improves user experience by aligning with intuitive UI conventions.
GSoC 2026:
This PR is submitted as part of the GSoC 2026 exam. Maintainers, could you please add the gsoc-2026 label?

@asoplata asoplata added the gsoc-2026 Use this label for "test" PRs where you are intending to demonstrate aptitude. label Feb 26, 2026
@asoplata
Copy link
Copy Markdown
Collaborator

Thanks for your PR Muhammad! I'm temporarily changing this to "blocked", since it is best if this change is made after we merge in #1243 , which we expect to do next week if we can. After that, this PR will have to be rebased onto master and the implementation may have to change. Also thanks for your interest in GSoC!

@m-ahmad-amin
Copy link
Copy Markdown
Contributor Author

Thanks for the clarification!
While this PR is blocked on #1243, please let me know if there’s anything else I could work on in the meantime that would be helpful or relevant for the GSoC projects. I’d be happy to contribute.

@asoplata
Copy link
Copy Markdown
Collaborator

Sorry for the wait Muhammad, I have merged #1243 so now, please rebase your changes onto the latest commit of master. You can find some advice on how rebasing generally works here https://jonescompneurolab.github.io/hnn-core/stable/contributing.html#keeping-your-code-up-to-date-by-rebasing .

@m-ahmad-amin m-ahmad-amin force-pushed the m-ahmad-amin/delete-all-drives-button-color branch from c8d89a4 to cc35994 Compare March 18, 2026 17:07
@m-ahmad-amin
Copy link
Copy Markdown
Contributor Author

I have rebased my changes onto the latest commit master. Let me know if there's anything else I can help with?

@asoplata
Copy link
Copy Markdown
Collaborator

Thanks Muhammad. Instead of passing a custom color to create_expanded_button, please change the "delete all drives" button so that it is built similarly to delete_button in the function add_drive_widget.

Also, if you're willing, it would be helpful to replace all uses of create_expanded_button with an equivalent Button widget call by itself, and then remove the function. Now that we've heavily refactored the GUI create_expanded_button is not really needed anymore and only adds confusion.

@m-ahmad-amin m-ahmad-amin force-pushed the m-ahmad-amin/delete-all-drives-button-color branch from cc35994 to 195ac48 Compare March 19, 2026 02:30
@m-ahmad-amin
Copy link
Copy Markdown
Contributor Author

I have refactored delete all drives button and now it is built similarly to the delete_button in the function add_drive_widget.
Thank you for trusting me for the second task of replacing all uses of create_expanded_button with an equivalent Button widget. I plan to do this in a separate branch and PR so it can be reviewed independently.

Could you please let me know how can I contact you regarding GSoC-related questions? I want to make sure I follow the preferred channel.

@asoplata
Copy link
Copy Markdown
Collaborator

Hello Muhammad, please do the second task inside this PR instead of creating a new one. These are small changes and it will be easier for me to review them all at once.

For GSOC questions, if you have general questions, feel free to ask them in the GSOC category of our Discussions page https://github.com/jonescompneurolab/hnn-core/discussions/categories/gsoc , or on this issue here #1202 , or on our gitter (available here https://github.com/jonescompneurolab/hnn-core ).

If you have specific questions about your proposal itself, then unfortunately this year we are not offering feedback on proposals before submission, in the interest of fairness to all participants.

@m-ahmad-amin
Copy link
Copy Markdown
Contributor Author

As you suggested I have replaced all uses of create_expanded_button with Button widget inside this PR. Please let me know if any further adjustments are needed.

Comment thread hnn_core/gui/gui.py
Comment thread hnn_core/gui/gui.py Outdated
self.delete_drive_button = Button(
description="Delete all drives",
button_style="danger",
icon="trash",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the icon used with the same as that of the individual Drive's icon.

Copy link
Copy Markdown
Collaborator

@asoplata asoplata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Muhammad - there's only a couple of small changes left to do, but after that we should be ready for merge! Thank you for your time.

@github-project-automation github-project-automation Bot moved this from Backlog to In review in HNN Workspace Turbo 9000 Mar 25, 2026
@m-ahmad-amin m-ahmad-amin force-pushed the m-ahmad-amin/delete-all-drives-button-color branch from 9e2d523 to 0e73330 Compare March 26, 2026 14:06
@m-ahmad-amin
Copy link
Copy Markdown
Contributor Author

Thanks for the guidance! I’ve applied the remaining requested changes.
Please let me know if anything else needs adjustment.

@asoplata asoplata enabled auto-merge (squash) March 26, 2026 19:05
@asoplata asoplata marked this pull request as draft March 27, 2026 17:01
auto-merge was automatically disabled March 27, 2026 17:01

Pull request was converted to draft

@asoplata asoplata marked this pull request as ready for review March 27, 2026 17:01
@asoplata asoplata force-pushed the m-ahmad-amin/delete-all-drives-button-color branch from 3e7a114 to 55acf04 Compare March 27, 2026 17:05
@asoplata asoplata enabled auto-merge (squash) April 1, 2026 16:54
@asoplata asoplata merged commit b95f686 into jonescompneurolab:master Apr 1, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gsoc-2026 Use this label for "test" PRs where you are intending to demonstrate aptitude.

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants