[MRG] ENH: change 'Delete all drives' button color to red for better UX#1245
Conversation
|
Thanks for your PR Muhammad! I'm temporarily changing this to "blocked", since it is best if this change is made after we merge in #1243 , which we expect to do next week if we can. After that, this PR will have to be rebased onto |
|
Thanks for the clarification! |
|
Sorry for the wait Muhammad, I have merged #1243 so now, please rebase your changes onto the latest commit of |
c8d89a4 to
cc35994
Compare
|
I have rebased my changes onto the latest commit master. Let me know if there's anything else I can help with? |
|
Thanks Muhammad. Instead of passing a custom color to Also, if you're willing, it would be helpful to replace all uses of |
cc35994 to
195ac48
Compare
|
I have refactored Could you please let me know how can I contact you regarding GSoC-related questions? I want to make sure I follow the preferred channel. |
|
Hello Muhammad, please do the second task inside this PR instead of creating a new one. These are small changes and it will be easier for me to review them all at once. For GSOC questions, if you have general questions, feel free to ask them in the GSOC category of our Discussions page https://github.com/jonescompneurolab/hnn-core/discussions/categories/gsoc , or on this issue here #1202 , or on our gitter (available here https://github.com/jonescompneurolab/hnn-core ). If you have specific questions about your proposal itself, then unfortunately this year we are not offering feedback on proposals before submission, in the interest of fairness to all participants. |
|
As you suggested I have replaced all uses of |
| self.delete_drive_button = Button( | ||
| description="Delete all drives", | ||
| button_style="danger", | ||
| icon="trash", |
There was a problem hiding this comment.
Please replace the icon used with the same as that of the individual Drive's icon.
asoplata
left a comment
There was a problem hiding this comment.
Thanks Muhammad - there's only a couple of small changes left to do, but after that we should be ready for merge! Thank you for your time.
… the function add_drive_widget
9e2d523 to
0e73330
Compare
|
Thanks for the guidance! I’ve applied the remaining requested changes. |
3e7a114 to
55acf04
Compare
This PR updates the “Delete all drives” button in the HNN GUI to red, making its destructive action more visually noticeable. The change improves user experience by aligning with intuitive UI conventions.
GSoC 2026:
This PR is submitted as part of the GSoC 2026 exam. Maintainers, could you please add the gsoc-2026 label?