Skip to content

TEST: Add edge case tests for option validation utilities#1256

Closed
bhumigaddam wants to merge 2 commits intojonescompneurolab:masterfrom
bhumigaddam:test-utils-edge-cases
Closed

TEST: Add edge case tests for option validation utilities#1256
bhumigaddam wants to merge 2 commits intojonescompneurolab:masterfrom
bhumigaddam:test-utils-edge-cases

Conversation

@bhumigaddam
Copy link
Copy Markdown

While exploring the testing infrastructure in HNN-Core, related to improving the testing infrastructure discussed in issue #1118.I noticed that some utility functions responsible for validating input options did not have
dedicated tests covering edge cases.

This PR adds a small set of tests that verify both valid and invalid option
handling for the _check_option utility function. The tests ensure that
valid inputs are accepted and that incorrect values raise the expected
exceptions.

Adding these edge-case tests helps strengthen the reliability of the
validation utilities and improves coverage for functions that are used
across different parts of the codebase.

I’m continuing to explore the testing infrastructure and look forward to
contributing further improvements.

@asoplata
Copy link
Copy Markdown
Collaborator

Hello bhumigaddam,

I see a new empty file named hnn_core/tests/test_utils_edge_cases.py, but as far as I can tell, the file is empty and has no code. Can you please add the code that you meant push to that file?

Also, please rebase your branch so that this PR's branch no longer contains the commit at 998215d, since that is a commit that is unrelated to this PR and instead belongs only on your other PR at #1255 . You can see some guidance for how to do this on our Contributing Guide here.

@bhumigaddam
Copy link
Copy Markdown
Author

Hi Austin, thanks for pointing this out.

I see the issues with the empty file and unrelated commits this PR isn’t in a clean state. I’m going to close it and open a fresh PR focused only on the intended test changes, following the contribution guidelines more carefully.

Appreciate your feedback.

@github-project-automation github-project-automation Bot moved this from Backlog to Done in HNN Workspace Turbo 9000 Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants