Open
Conversation
|
Here is a implementation which does not require Clone and avoids recursion based on a bottom up strategy. It does require unsafe and MaybeUninit. I'm not an expert in unsafe code so I'm not sure if it is actually all memory safe but it appears to be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works, but does too many allocations. Also, merge sort needs to keep a copy of the array, so I added a
CloneSortertrait that adds the requirement thatTisClone. It might make more sense to changeSortertoSorter<T>and let the sort implementations choose what traits to require (radix sort for example isn't a comparison sort, but should work for anything that can be converted into a byte array that compares the same way as the underlying type (integers, strings, composite structs, etc.)), but that's out of the scope of this pull request. An alternative is to requireT: Ord+Cloneon sorter directly.