[QuickSort] clean the left param +1/-1, beautify judgment conditions#9
Open
PhzCode wants to merge 1 commit intojonhoo:masterfrom
Open
[QuickSort] clean the left param +1/-1, beautify judgment conditions#9PhzCode wants to merge 1 commit intojonhoo:masterfrom
PhzCode wants to merge 1 commit intojonhoo:masterfrom
Conversation
jonhoo
reviewed
Jan 8, 2022
| // already on the correct side | ||
| left += 1; | ||
| } else if &rest[right] > pivot { | ||
| } else if &rest[right] > pivot && right > 0 { |
Owner
There was a problem hiding this comment.
I don't think this conditional change is necessary? After all, we won't get here with the new right > 0 in the while conditional.
jonhoo
reviewed
Jan 8, 2022
| let mut left = 0; | ||
| let mut right = rest.len() - 1; | ||
| while left <= right { | ||
| // if right <= 0, it's done |
Owner
There was a problem hiding this comment.
Maybe also point out here (this helped me) that if right <= 0, then left == right, so there can't be a need to swap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the
whilejudgment conditions and remove the unused +1/-1 for theleftparam