Skip to content

Original :octocat: should be attributed to correct author #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonico wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Original :octocat: should be attributed to correct author #5

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ae4f4a
Adjusted test cases to not exclude original octocat any more
jonico Oct 13, 2023
3061446
Merge branch 'main' into every-octocat-should-have-an-author
jonico Oct 13, 2023
94c0a64
Simon is the original author
jonico Oct 13, 2023
e4d9076
Remove Simon temporarily
jonico Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions postman/collections/Octodex REST API.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,21 +53,21 @@
"",
"pm.visualizer.set(template, constructVisualizerPayload());",
"",
"pm.test(\"At least 100 octocats (excluding the 'Original' octocat) are returned within less than a second\", function () {",
"pm.test(\"At least 100 octocats are returned within less than a second\", function () {",
" var responseData = pm.response.json();",
" var octocats = responseData.data.filter(function(item) {",
" return item.octocat !== \"\" && item.title !== \"Original\";",
" return item.octocat !== \"\";",
" });",
"",
" pm.expect(octocats.length).to.be.greaterThan(100, \"At least 100 octocats (excluding the 'Original' octocat) should be returned\");",
"",
" pm.expect(pm.response.responseTime).to.be.below(1000, \"Response time should be less than a second\");",
"});",
"",
"pm.test(\"Each octocat (excluding the 'Original' octocat) has at least one author\", function() {",
"pm.test(\"Each octocat has at least one author\", function() {",
" var responseData = pm.response.json();",
" var octocats = responseData.data.filter(function(item) {",
" return item.title !== \"Original\";",
" return item.title !== \"\";",
" });",
"",
" octocats.forEach(function(octocat) {",
Expand Down