Skip to content

Another PR to fix website behaviour for private buckets#390

Open
jonny-rimek wants to merge 3 commits intoprodfrom
bucket
Open

Another PR to fix website behaviour for private buckets#390
jonny-rimek wants to merge 3 commits intoprodfrom
bucket

Conversation

@jonny-rimek
Copy link
Copy Markdown
Owner

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 9, 2021

Stack wm
Resources
[~] AWS::Lambda::Function Api-/Lambda ApiLambdaB75D04FB 
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] 4416d1d86915fb69691e0cd07961497ba585c9fbfc3b20522980968340532e85.zip
 │       └─ [+] 2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.4416d1d86915fb69691e0cd07961497ba585c9fbfc3b20522980968340532e85
         └─ [+] asset.2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e
[~] AWS::CloudFront::Distribution Frontend-/Distribution FrontendDistributionBC7F184B 
 └─ [~] DistributionConfig
     ├─ [~] .CustomErrorResponses:
     │   └─ @@ -4,11 +4,5 @@
     │      [ ]     "ErrorCode": 404,
     │      [ ]     "ResponseCode": 200,
     │      [ ]     "ResponsePagePath": "/index.html"
     │      [-]   },
     │      [-]   {
     │      [-]     "ErrorCachingMinTTL": 0,
     │      [-]     "ErrorCode": 403,
     │      [-]     "ResponseCode": 200,
     │      [-]     "ResponsePagePath": "/index.html"
     │      [ ]   }
     │      [ ] ]
     ├─ [~] .DefaultCacheBehavior:
     │   ├─ [-] Removed: .OriginRequestPolicyId
     │   └─ [~] .ViewerProtocolPolicy:
     │       ├─ [-] redirect-to-https
     │       └─ [+] allow-all
     └─ [~] .Origins:
         └─ @@ -3,7 +3,7 @@
            [ ] "DomainName": {
            [ ]   "Fn::GetAtt": [
            [ ]     "FrontendBucket14D51EE9",
            [-]     "RegionalDomainName"
            [+]     "DomainName"
            [ ]   ]
            [ ] },
            [ ] "Id": "wmFrontendDistributionOrigin1E9A172D6",
[~] Custom::CDKBucketDeployment Frontend-/DeployWebsite/CustomResource FrontendDeployWebsiteCustomResource1B4A6C7F 
 └─ [~] SourceObjectKeys
     └─ @@ -1,3 +1,3 @@
        [ ] [
        [-]   "363e05dacede10ebde7174ced2a664475d83cb73fd7b219eb37be3dae5885c5b.zip"
        [+]   "1797a930cfc8682d15de84799ab92d47d652d84f975bd75797cc2692075f6efe.zip"
        [ ] ]

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 9, 2021

Stack wm
IAM Statement Changes
┌───┬───────────────────────────┬────────┬──────────────┬────────────────────────────────────────────────────────────────────────────────┬───────────┐
│   │ Resource                  │ Effect │ Action       │ Principal                                                                      │ Condition │
├───┼───────────────────────────┼────────┼──────────────┼────────────────────────────────────────────────────────────────────────────────┼───────────┤
│ - │ ${Frontend-/Bucket.Arn}/* │ Allow  │ s3:GetObject │ CanonicalUser:${FrontendDistributionOrigin1S3Origin4EF580DE.S3CanonicalUserId} │           │
└───┴───────────────────────────┴────────┴──────────────┴────────────────────────────────────────────────────────────────────────────────┴───────────┘
(NOTE: There may be security-related changes not in this list. See https://github.com/aws/aws-cdk/issues/1299)

Resources
[-] AWS::S3::BucketPolicy FrontendBucketPolicy9C3048D5 destroy
[-] AWS::CloudFront::CloudFrontOriginAccessIdentity FrontendDistributionOrigin1S3Origin4EF580DE destroy
[~] AWS::Lambda::Function Api-/Lambda ApiLambdaB75D04FB 
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] 4416d1d86915fb69691e0cd07961497ba585c9fbfc3b20522980968340532e85.zip
 │       └─ [+] 2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.4416d1d86915fb69691e0cd07961497ba585c9fbfc3b20522980968340532e85
         └─ [+] asset.2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e
[~] AWS::S3::Bucket Frontend-/Bucket FrontendBucket14D51EE9 
 └─ [+] WebsiteConfiguration
     └─ {"IndexDocument":"index.html"}
[~] AWS::CloudFront::Distribution Frontend-/Distribution FrontendDistributionBC7F184B 
 └─ [~] DistributionConfig
     ├─ [~] .CustomErrorResponses:
     │   └─ @@ -4,11 +4,5 @@
     │      [ ]     "ErrorCode": 404,
     │      [ ]     "ResponseCode": 200,
     │      [ ]     "ResponsePagePath": "/index.html"
     │      [-]   },
     │      [-]   {
     │      [-]     "ErrorCachingMinTTL": 0,
     │      [-]     "ErrorCode": 403,
     │      [-]     "ResponseCode": 200,
     │      [-]     "ResponsePagePath": "/index.html"
     │      [ ]   }
     │      [ ] ]
     ├─ [~] .DefaultCacheBehavior:
     │   ├─ [-] Removed: .OriginRequestPolicyId
     │   └─ [~] .ViewerProtocolPolicy:
     │       ├─ [-] redirect-to-https
     │       └─ [+] allow-all
     └─ [~] .Origins:
         └─ @@ -1,28 +1,21 @@
            [ ] [
            [ ]   {
            [+]     "CustomOriginConfig": {
            [+]       "OriginProtocolPolicy": "http-only",
            [+]       "OriginSSLProtocols": [
            [+]         "TLSv1.2"
            [+]       ]
            [+]     },
            [ ]     "DomainName": {
            [ ]       "Fn::GetAtt": [
            [ ]         "FrontendBucket14D51EE9",
            [-]         "RegionalDomainName"
            [+]         "DomainName"
            [ ]       ]
            [ ]     },
            [ ]     "Id": "wmFrontendDistributionOrigin1E9A172D6",
            [ ]     "OriginShield": {
            [ ]       "Enabled": true,
            [ ]       "OriginShieldRegion": "us-east-1"
            [-]     },
            [-]     "S3OriginConfig": {
            [-]       "OriginAccessIdentity": {
            [-]         "Fn::Join": [
            [-]           "",
            [-]           [
            [-]             "origin-access-identity/cloudfront/",
            [-]             {
            [-]               "Ref": "FrontendDistributionOrigin1S3Origin4EF580DE"
            [-]             }
            [-]           ]
            [-]         ]
            [-]       }
            [ ]     }
            [ ]   }
            [ ] ]
[~] Custom::CDKBucketDeployment Frontend-/DeployWebsite/CustomResource FrontendDeployWebsiteCustomResource1B4A6C7F 
 └─ [~] SourceObjectKeys
     └─ @@ -1,3 +1,3 @@
        [ ] [
        [-]   "363e05dacede10ebde7174ced2a664475d83cb73fd7b219eb37be3dae5885c5b.zip"
        [+]   "1797a930cfc8682d15de84799ab92d47d652d84f975bd75797cc2692075f6efe.zip"
        [ ] ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant