Fix KellyBet formula: use payout-1 for net odds - #14
Merged
Merged
Conversation
The formula was dividing payout by 2 instead of subtracting 1. Since payout represents decimal odds, net odds = payout - 1. Also adds a guard for payout <= 1 (division by zero / negative net odds) and expands tests with table-driven cases covering edge cases. Fixes #9 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KellyBet()to usepayout - 1instead ofpayout / 2for calculating net odds from decimal oddspayout <= 1(prevents division by zero and negative net odds)Test plan
payout <= 1return 0.0go vetpasses cleanlyFixes #9
🤖 Generated with Claude Code