Return Bet object from PostBet - #16
Merged
Merged
Conversation
PostBet now returns (*Bet, error) instead of just error, exposing the full Bet object from the Manifold API response. This includes the bet ID (needed for CancelBet), shares, probability impact, fees, and fill details for limit orders. Fixes #15 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Manifold API returns "betId" (not "id") from POST /v0/bet. Add BetId field to Bet struct and normalize to Id in PostBet so callers can consistently use bet.Id. Verified against live Manifold API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jonnyspicer
force-pushed
the
fix/issue-15-postbet-return-bet
branch
from
February 16, 2026 04:51
2492bf6 to
2b892a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PostBetsignature fromerrorto(*Bet, error)to expose the API responseparseResponsegeneric to deserialize the response body into aBetBreaking change
This changes the
PostBetreturn type. Callers usingerr := mc.PostBet(...)will need to update tobet, err := mc.PostBet(...)(or_, err :=to preserve existing behavior).Test plan
go test ./...passesgo vet ./...cleanFixes #15
🤖 Generated with Claude Code