Fix: gradients, textures and animations now apply in both modes#16
Merged
Conversation
The previous version put the background, texture and animation on the Board's outer Stack, and rows fell back to bg.from when no per-line colour was set — so the rows painted opaque over the gradient/texture and hid every effect except the row colour itself. Photo mode bypassed all of it because BigPicture just rendered an image with no overlay. Hoist the visual layers into a new Stage component that wraps both the Board and BigPicture: - Stage owns the gradient background, texture overlay, texture animation, and the shimmer pass. - Board only renders rows. Rows default to transparent; an explicit Line.color is the only thing that paints over the Stage. - BigPicture renders just the image (or nothing if none uploaded), so the Stage's gradient and texture show through around contained images and behind a missing one. Result: gradients, dots/stripes/grid/noise, pan/pulse/shimmer all render the same in normal mode and photo mode. https://claude.ai/code/session_011pGzV6osudSkwYLZ93A74R
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version put the background, texture and animation on the Board's outer Stack, and rows fell back to bg.from when no per-line colour was set — so the rows painted opaque over the gradient/texture and hid every effect except the row colour itself. Photo mode bypassed all of it because BigPicture just rendered an image with no overlay.
Hoist the visual layers into a new Stage component that wraps both the Board and BigPicture:
Result: gradients, dots/stripes/grid/noise, pan/pulse/shimmer all render the same in normal mode and photo mode.
https://claude.ai/code/session_011pGzV6osudSkwYLZ93A74R