Skip to content

Fix long-submit timeout errback for multipart SubmitSm transactions #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mustafatasli wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix long-submit timeout errback for multipart SubmitSm transactions #1263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion jasmin/protocols/smpp/protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,11 @@ def cancelLongSubmitSmTransactions(self, err):
# Do errback
txn.ackDeferred.errback(err)

def onLongSubmitSmTransactionTimeout(self, reqPDU, timeout):
txn = self.closeLongSubmitSmTransaction(reqPDU.LongSubmitSm['msg_ref_num'])
errMsg = 'Long submit_sm transaction timed out after %s secs: %s' % (timeout, reqPDU)
txn.ackDeferred.errback(SMPPRequestTimoutError(errMsg))

def startLongSubmitSmTransaction(self, reqPDU, timeout):
if reqPDU.LongSubmitSm['msg_ref_num'] in self.longSubmitSmTxns:
self.log.error(
Expand All @@ -181,7 +186,7 @@ def startLongSubmitSmTransaction(self, reqPDU, timeout):
# Create callback deferred
ackDeferred = defer.Deferred()
# Create response timer
timer = reactor.callLater(timeout, self.onResponseTimeout, reqPDU, timeout)
timer = reactor.callLater(timeout, self.onLongSubmitSmTransactionTimeout, reqPDU, timeout)
# Save transaction
self.longSubmitSmTxns[reqPDU.LongSubmitSm['msg_ref_num']] = {
'txn': SMPPOutboundTxn(reqPDU, timer, ackDeferred),
Expand Down