Conversation
added 3 commits
January 8, 2015 13:34
…mplementation of filewatch gem AND creating hpuxhelder.rb (not yet implemented) file based on windowsHelper.rb file
M0dM
changed the title
added 4 commits
January 9, 2015 14:44
Conflicts: lib/filewatch/tail.rb
…e unique identifier. Adding most hpux specific code inside the hpuxhelper.rb module. Signed-off-by: Benoit Brayer <benoit.brayer@st.com>
removing end lines spaces converting line break to respect unix standard changing _sincedb_write method file open mode -> solve sincedb file initializing problem
M0dM
changed the title
Author
|
Why did you not merge my PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just forked your projet because I want to use logstash under HP-UX.
The problem is because the ruby FFI library does not support HP-UX os, the File::Stat command just perform strangly on the system (stat.inode always return 0, dev_minor and dev_major does not exist).
So, I published this small workaround using the inode and the filesystem mount point name as unique identifier for the watched file.
To get these properties, I had to call these bash commands :
ls -i
df -n
I surrounded every hp-ux specific code with the @ishpux annotation to be certain to do no break anything for any other platform.
I also created an hpux helper class.
Thanks for your good work.
Edit : I also moved the java folder inside the lib folder because this operation was required to make logstash work properly. Otherwise a NotFoundExection occured.
Benoit Brayer