Skip to content

Update to active_support 4.2.4 - #68

Open
MichaelSp wants to merge 2 commits into
jordansissel:masterfrom
MichaelSp:master
Open

MichaelSp wants to merge 2 commits into
jordansissel:masterfrom
MichaelSp:master

Conversation

@MichaelSp

Copy link
Copy Markdown
Minitest::UnexpectedError: ArgumentError: wrong number of arguments (2 for 1)
    /home/michael/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/filewatch-0.6.4/lib/filewatch/helper.rb:19:in `atomic_write'
    /home/michael/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/cache/file_store.rb:83:in `write_entry'

Current version of active_support (4.2.4) uses 2 arguments.
Result is that filewatch is incompatible with active_support 4.2.4

fixes #67

@jsvd

jsvd commented Dec 2, 2015

Copy link
Copy Markdown
Collaborator

To avoid further conflicts, I'd suggest changing the namespace of this method to FileWatch or FileWatch::File, what do you think @MichaelSp ?

@MichaelSp

Copy link
Copy Markdown
Author

Yes, sounds like a plan.

@MichaelSp

Copy link
Copy Markdown
Author

anything I can do to get this released?

@guyboertje

guyboertje commented Aug 10, 2016

Copy link
Copy Markdown
Contributor

@MichaelSp - this has been implemented in this PR along with a bunch of other overdue changes...
See https://github.com/jordansissel/ruby-filewatch/pull/79/files#diff-d5c5655c1c01ef1837bf4fa11533221cR7

We just need some developer time to complete the PR review cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

filewatch/helper File#atomic_write requires update

3 participants