Repository navigation
fix(bryton): prevent generated workout filename collisions - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bryton uploads generated in the same second previously received identical filenames. When Bryton file IDs are unavailable, those names become persisted deduplication keys, so one workout can incorrectly make another appear to still exist.
Append a full UUID4 suffix to the existing timestamp-based filename. This gives uploads independent names even at the same timestamp and across separate processes. The shared generator also covers uploads with a blank filename.
Follow-up to the filename collision reported in #57. Existing stored names remain supported; force re-sync replacement behavior is outside this change.
Validation
git diff --checkpassed.Bryton device/server behavior has not been tested live.