Skip to content

fix(igpsport): preserve activity start times in Dropbox exports - #67

Merged
jorge-huxley merged 2 commits into
masterfrom
fix/igpsport-activity-start-time
Nov 4, 2026
Merged

jorge-huxley merged 2 commits into
masterfrom
fix/igpsport-activity-start-time

Conversation

@jorge-huxley

@jorge-huxley jorge-huxley commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Summary

When iGPSPORT returns a date-only startTime in its activity list, Dropbox filenames currently contain 00-00-00 and separate rides on the same day can collide. Fetch the full startTime from queryActivityDetail before any consumer uses the activity, restoring the actual time in Dropbox filenames, skip decisions, progress output, CLI JSON, and activity date-range checks.

Closes #66.

Changes

  • Enrich activities whose list timestamp has no time using the regional activity-detail endpoint; preserve complete list timestamps.
  • Reuse the detail response's FIT URL instead of fetching it again for downloads.
  • Use unique ride-ID filenames if details are unavailable or still omit the time; retain date-only values for date-range checks and preserve genuine midnight timestamps.
  • Check out the publishing script in the release job so the release candidate can publish. This corrects an existing master workflow failure.

Verification

  • Full offline suite: 291 tests passed.
  • Regression coverage for International and China endpoints, two rides on the same day, incomplete/malformed/unavailable details, genuine midnight, corrected Dropbox skip decisions, progress/CLI output, and FIT URL reuse.
  • Read-only verification against a configured live account: three latest rides return full timestamps and correctly timed filenames. No activities were uploaded or changed.
  • Reporter tests the v0.9.5-rc2 desktop/Android build before merge.

Notes / follow-ups

Branch created from origin/master. Release candidate v0.9.5-rc2 is built from this PR, independently of the unmerged Bryton China branch. Leave this PR unmerged until the reporter confirms the fix on their Binavi Ultra.

Existing files with midnight filenames are left in Dropbox; a subsequent sync uploads the correctly named file. Re-running then skips the corrected file normally.

@jorge-huxley
jorge-huxley merged commit f15304c into master Nov 4, 2026
7 checks passed
@jorge-huxley
jorge-huxley deleted the fix/igpsport-activity-start-time branch November 4, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropbox exporting bug

1 participant