Repository navigation
fix(igpsport): preserve activity start times in Dropbox exports - #67
Merged
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When iGPSPORT returns a date-only startTime in its activity list, Dropbox filenames currently contain 00-00-00 and separate rides on the same day can collide. Fetch the full startTime from queryActivityDetail before any consumer uses the activity, restoring the actual time in Dropbox filenames, skip decisions, progress output, CLI JSON, and activity date-range checks.
Closes #66.
Changes
Verification
Notes / follow-ups
Branch created from origin/master. Release candidate v0.9.5-rc2 is built from this PR, independently of the unmerged Bryton China branch. Leave this PR unmerged until the reporter confirms the fix on their Binavi Ultra.
Existing files with midnight filenames are left in Dropbox; a subsequent sync uploads the correctly named file. Re-running then skips the corrected file normally.