Repository navigation
fix(bryton): support China-region accounts - #68
Merged
Merged
Conversation
Bryton runs separate international and China backends. Add a region setting for the GUI and INTERVALSSYNC_BRYTON_REGION for the CLI, then resolve the DDP/FIT/workout hosts from it. Fixes #64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bryton China-region accounts currently receive a "user not found" error because login uses the international backend. Add an independent Bryton region setting so activity sync and planned workout uploads use the backend where the account was created.
Closes #64.
Changes
INTERVALSSYNC_BRYTON_REGIONfor the CLI, defaulting to International.Verification
python -m pytest -q -p no:cacheprovider, with a writable temporary directory).git diff --checkpassed.v0.9.5-rc1, this branch, and the successful release workflow all point toa04bf1ad9d9d76cd1287a50758fba5878a323337.Notes / follow-ups
The tested candidate is available at https://github.com/jorge-huxley/intervalssync/releases/tag/v0.9.5-rc1. A subsequent stable release is needed to deliver the fix through stable distribution channels.