Internal build - #1
Open
joshanne wants to merge 17 commits into
Open
Conversation
…s not just default
… connection is previously closed Receiving a zero-byte payload now triggers socket disconnect instead of failing silently. Prevents dropped connections from leaving the serial passthrough unresponsive.
Allows for plugins to be loaded from ~/dronecan_gui_tool/plugin builds
Unrecognised data type IDs (e.g. while prototyping new DSDL that isn't built into the tool) caused two distinct failures. First, they tripped the 1000-strike successive-error guard and terminated the local node after a few seconds, logging a full traceback on every 10 ms spin. Second, and more subtly: Node.spin() drains the RX queue and then runs its scheduler, but when Transfer.from_frames() raises on an undecodable transfer the drain aborts and the scheduler poll is skipped. The node monitor's liveness is scheduler-driven (periodic stale-sweep and outstanding-request timeouts), so at high message rates the scheduler is starved -- nodes flap in and out of the monitor and the UI stalls. Wrap Node._recv_frame so an undecodable transfer is dropped in place, letting spin() finish draining the queue and schedule normally. Keep a backstop catch in the spin loop that no longer counts these towards the fatal threshold, and throttle the logging so a high-rate unknown message cannot flood the log.
Because the version is only incremented prior to a release, we have a number of commits between releases that all identify as the last release. This means, all of our most recent changes that have improved gui_tool look like it's an old version, and managing users installs is hard. 'But it works on v1.2.28' - when it's actually a dev build the user is running...
Precedence for version information: * git describe * setuptools_scm generated file * .git_archival.txt * default value
joshanne
force-pushed
the
internal-build
branch
from
September 2, 2026 04:57
d485d36 to
ab97955
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.