Prevent zip path traversal during archive extraction#90
Closed
joshyorko wants to merge 1 commit into
Closed
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
Superseded by #97, which stacks this hardening change into the grouped release PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
zipEntryTarget(directory, entry string) (string, error)helper inoperations/zipper.gothat builds the candidate target path and rejects entries whose cleaned relative path begins with...zipEntryTargetfrom the parallel extractor (Explode) and the single-threaded extractor (Extract) so all archive extraction flows validate containment before writing.operations/initialize.go) to cover embedded/template archive handling.operations/zipper_test.goto verify accepting a normal nested path and rejecting a traversal path.Testing
gofmton modified files usinggofmt -wto ensure formatting was applied successfully.GOARCH=amd64 CGO_ENABLED=0 go test ./operations -run 'TestCanConvertSlashes|TestZipEntryTarget', which failed in this environment due to missing generated assets referenced byblobs/embedded.go(setup failure), not due to the change itself.Codex Task