Prevent Zip Slip by validating unzip targets#95
Closed
joshyorko wants to merge 1 commit into
Closed
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
Superseded by #97, which stacks this hardening change into the grouped release PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
hololib.zipfrom untrusted bundles becauseUnzipconstructed extraction paths withfilepath.Joinand wrote them without containment checks.importHololibcannot cause arbitrary file writes outside the intended destination.Description
safeExtractTarget(directory, entry)inoperations/zipper.goto canonicalize and validate that a cleaned extraction target stays inside the destination directory.unzipper.Extractto callsafeExtractTargetfor each entry and reject entries that escape the destination.operations/zipper_test.gocovering a malicious traversal entry (TestUnzipRejectsPathTraversal) and a normal extraction (TestUnzipExtractsRegularFile).Testing
gofmt -w operations/zipper.go operations/zipper_test.gosuccessfully to format the changes.GOARCH=amd64 CGO_ENABLED=0 go test ./operations, which failed in this environment due to missing generated embedded assets (blobs/embedded.go: pattern assets/*.py: no matching files found) and prevented running the package tests here.Codex Task