Conversation
rkistner
left a comment
rkistner
left a comment
There was a problem hiding this comment.
Looks good overall, just added some minor comments.
| @@ -0,0 +1,8 @@ | |||
| { | |||
There was a problem hiding this comment.
Is lerna used anywhere here, or can we remove it? (this config file + the dependency)
There was a problem hiding this comment.
Its used in the dev package publishing:
uses: ./.github/ci/actions/pnpm-publish with: dev: true
There was a problem hiding this comment.
This was based of what Wessel had done in the pdf-report repo.
There was a problem hiding this comment.
But i guess I could use changeset rather, maybe I should just do that
There was a problem hiding this comment.
It should be possible to simplify this to just use pnpm + changesets directly, see this example: https://github.com/powersync-ja/powersync-service/blob/indexed-compact/.github/workflows/development_packages_release.yaml#L49-L56
Even pnpm workspaces should not be needed since the repo only contains a single package.
But those are bigger changes and not important, so let's leave it like this for now.
There was a problem hiding this comment.
I did not want to make any big changes off of what Wessels did as I was not sure if things were done for a reason which would cause me to then revert everything.
2 participants
pnpmas package manager.