[Chore] Bump node and remove node-fetch#15
Merged
Conversation
Replaced `node-fetch` with native `fetch` now bundled with `node`
… are incompatible with CC `1.12`
Manrich121
reviewed
Jul 8, 2025
| *.tsbuildinfo | ||
|
|
||
| .idea | ||
| .env No newline at end of file |
Collaborator
There was a problem hiding this comment.
Please add a .env.template with the empty keys and JOURNEY_PDF_KEY for local dev
Manrich121
reviewed
Jul 8, 2025
src/docraptor.ts
Outdated
| } | ||
|
|
||
| return new PdfResult(await response.buffer()); | ||
| return new PdfResult(Buffer.from(await response.arrayBuffer())); |
Collaborator
There was a problem hiding this comment.
Please create a helper function that will do this Buffer.from(...) under the hood. It can be imported as fetch and the response be used like in the past await response.buffer()
Manrich121
reviewed
Jul 8, 2025
yarn.lock
Outdated
| @@ -2,17 +2,30 @@ | |||
| # yarn lockfile v1 | |||
Collaborator
There was a problem hiding this comment.
Upgrade this repo to use PNPM instead
Busy adding GitHub actions for testing, dev and production publishes
…n on responses again.
…a standalone test workflow
[Chore] Migrate to `pnpm` and GitHub actions
Manrich121
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CloudCode
1.15has been bumped to use node22.15andnode-fetchis no longer being used as the globalfetchimplementation in favor of the nativefetchnow included with the newernodeversion.We're updating this package to match the node version and also removing the
node-fetchdependency.QA
1.0.0on CC1.12and got no errors1.0.0on CC1.15and got the same missing package error as the customer1.1.0-dev.1on CC1.15and got no errors1.1.0-dev.1on CC1.12and got no errors (Althoughfetchdidn't get used, so might still be incompatible)Reason for
majorversion bump to2.0.0Native
fetchhas been introduced in node18as experimental and in node21as stable. Since the dependency is added on templates and such with the semver caret (e.g."@journeyapps/pdf-reports": "^1.0.0") users run the risk of using the new pdf-reports version on an older CC task which could cause issues.Checklist