feat: upgrade persona workflow to collaborative task with shared context#10
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb4e548918
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def research_task(persona) -> str: | ||
| return f"Researching with skills: {', '.join(persona.skills)}" | ||
| def research_task(persona: Persona, context: TaskContext) -> str: | ||
| design_result = context.get_result(design_persona.name) |
There was a problem hiding this comment.
research_task reads the prerequisite output using the module-level design_persona.name, so the collaborative handoff breaks whenever this function is reused with a different design persona/key in the same TaskContext (it will report no upstream result even after design work was recorded). This makes the new shared-context workflow incorrect outside the single hard-coded persona set.
Useful? React with 👍 / 👎.
| def marketing_task(persona) -> str: | ||
| return f"Marketing with skills: {', '.join(persona.skills)}" | ||
| def marketing_task(persona: Persona, context: TaskContext) -> str: | ||
| research_result = context.get_result(research_persona.name) |
There was a problem hiding this comment.
marketing_task pulls prior context via the module-level research_persona.name, so any workflow variant that runs marketing after a different research persona/key will silently lose the expected handoff (built on data is omitted despite available context). This introduces incorrect behavior in the new shared-context design whenever personas are not the hard-coded globals.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
Starting Task:
Designing with skills: UI Design, UX Research, Prototyping, Adobe XD, Figma
Researching with skills: literature search, information synthesis, technical explanation | informed by: Designing with skills: UI Design, UX Research, Prototyping, Adobe XD, Figma
Marketing with skills: copywriting, campaign design, product positioning | built on: Researching with skills: literature search, information synthesis, technical explanation | informed by: Designing with skills: UI Design, UX Research, Prototyping, Adobe XD, Figma
Task: Market Research & Design Collaboration
Progress:
Design Persona: Designing
Research Persona: Researching
Marketing Persona: Marketing
Results:
Design Persona: Designing with skills: UI Design, UX Research, Prototyping, Adobe XD, Figma
Research Persona: Researching with skills: literature search, information synthesis, technical explanation | informed by: Designing with skills: UI Design, UX Research, Prototyping, Adobe XD, Figma
Marketing Persona: Marketing with skills: copywriting, campaign design, product positioning | built on: Researching with skills: literature search, information synthesis, technical explanation | informed by: Designing with skills: UI Design, UX Research, Prototyping, Adobe XD, Figma
Notes