Add custom label colors for textbox mode by karenhes · Pull Request #18 · jpdefrutos/annotationweb_lung

karenhes · 2026-03-25T12:25:50Z

The color is now linked to the label in textbox mode, i.e., if you choose label 1 you get a specific color for all images with label 1. I hope this is easier to review!

Copilot

Pull request overview

This PR links textbox-mode custom labels to deterministic colors, so the same label text renders consistently across frames/images and persists server-side when saving annotations.

Changes:

Generate a deterministic hex color from custom label text on the client and apply it to slider markers / label display.
Send a custom_frame_label_colors mapping (label name → RGB) to the backend during save.
Persist custom label colors in save_labels() when creating/using Label rows.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

File	Description
`subsequence_classification/views.py`	Parses posted custom label colors and applies them to `Label` records when saving subsequence annotations.
`subsequence_classification/static/subsequence_classification/subsequence_classification.js`	Adds deterministic label→color hashing, includes color mapping in save payload, and updates UI coloring for textbox-mode labels.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-25T12:29:14Z

+                        print(f"Custom label: {custom_label}, Created: {created}, Colors: {custom_label_colors.get(custom_label)}")
+                        #if created:


This debug print(...) logs user-provided label values/colors and will add noise in production. Please switch to the project’s logging approach (or remove) so sensitive/user-input data isn’t printed to stdout.

Copilot · 2026-03-25T12:29:15Z

                        label, created = Label.objects.get_or_create(
                            name=custom_label,
                            #task=annotation.image_annotation.task,
-                            defaults={'color_red': 0, 'color_green': 255, 'color_blue': 0}
+                            #defaults={'color_red': 0, 'color_green': 255, 'color_blue': 0}
                        )


Same issue as above: Label.objects.get_or_create(name=custom_label) can throw MultipleObjectsReturned because Label.name is not unique. Use a safe lookup/create approach or add a uniqueness constraint to prevent save failures.

Copilot · 2026-03-25T12:29:15Z

        $('#currentFrameLabel').text(customLabel);
        $('#currentFrameLabelDisplay').text(customLabel);
+
+        $('#currentFrameLabel').html(`<span style="color: ${color}">${customLabel}</span>`);
+        $('#currentFrameLabelDisplay').html(
+            `<span style="color: ${color}">${customLabel}</span>`
+        );


customLabel comes from user input, but it’s interpolated into .html(...) without escaping, which enables XSS (e.g., a label like <img src=x onerror=...>). Use .text() and set the color via CSS (or build a span element and set textContent) instead of inserting raw HTML.

Suggested change

$('#currentFrameLabel').text(customLabel);

$('#currentFrameLabelDisplay').text(customLabel);

$('#currentFrameLabel').html(`${customLabel}`);

$('#currentFrameLabelDisplay').html(

`${customLabel}`

);

const customLabelSpan = $('').text(customLabel).css('color', color);

$('#currentFrameLabel').empty().append(customLabelSpan.clone());

$('#currentFrameLabelDisplay').empty().append(customLabelSpan);

Copilot · 2026-03-25T12:29:16Z

                        label, created = Label.objects.get_or_create(
                            name=custom_label,
                            #task=annotation.image_annotation.task,
-                            defaults={'color_red': 128, 'color_green': 128, 'color_blue': 128}
+                            #defaults={'color_red': 128, 'color_green': 128, 'color_blue': 128}
                        )


Label.objects.get_or_create(name=custom_label) can raise MultipleObjectsReturned if the DB already contains multiple Label rows with the same name (the Label.name field is not unique). Consider enforcing uniqueness (model constraint) or switching to a deterministic selection strategy (e.g., filter(name=...).order_by('id').first() plus create-if-missing) so saves don’t intermittently 500.

jpdefrutos

The funcionality works as expected. Some corrections and checks need to be put in place before approving.

Ideally, the "textbox" label functionality should be compatible with predefined labels. This can be set as a feature to be added later on.

jpdefrutos · 2026-04-16T09:18:41Z


 }

+function stringToColor(str) {


When the new label is similar to a previously defined one e.g., LabelA and LabelB, the generated colour is the same. Check whether the generated colour has already been used, and change it otherwise.

Ok, I can try to fix this, but haven't done it yet.

ok, submit your changes when done :)

jpdefrutos · 2026-04-16T09:22:14Z

 }

-function addLabelButton(label_id, label_name, red, green, blue, parent_id) {
+function addLabelButton(label_id, label_name,  color_red, color_green, color_blue, parent_id) {


These changes are not related to the original PR.

Ok, I changed it because it was defined like color_red in the views.py, but maybe it doesn't matter?

It doesn't matter

Fixed reverted to red, green and blue in the latest commit.

jpdefrutos · 2026-04-16T09:48:23Z

                            name=custom_label,
                            #task=annotation.image_annotation.task,
-                            defaults={'color_red': 0, 'color_green': 255, 'color_blue': 0}
+                            #defaults={'color_red': 0, 'color_green': 255, 'color_blue': 0}


Remove unused code

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Label exists and already has a colour, this should be preserved Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…into feature/textbox-colored-labels

jpdefrutos · 2026-04-17T14:52:29Z

 }

-function addLabelButton(label_id, label_name, red, green, blue, parent_id) {
+function addLabelButton(label_id, label_name,  color_red, color_green, color_blue, parent_id) {


It doesn't matter

jpdefrutos · 2026-04-17T14:53:25Z


 }

+function stringToColor(str) {


ok, submit your changes when done :)

…ToColor function now checks whether the generated colour has already been used, and changes it otherwise.

Replace the cycling fixed-palette approach with a hash-based color generation scheme aligned with PR #18 (feature/textbox-colored-labels): - Add stringToColor() using the polynomial hash + golden angle (137.508°) mapping to HSL hue, so similar labels get visually distinct colors - Add hslToHex() helper to produce well-saturated, consistent colors - Cache label→color in g_labelColorMap so the same label always gets the same color within and across sessions - Auto-create missing Label entries in the shared Label model (with RGB color) and link them to the task on save, if not already present - Drop BronchoscopyBoundingBox.color — color is now derived from the label name rather than stored per box

Add custom label colors fro textbox mode

211cf31

karenhes requested review from Copilot and jpdefrutos March 25, 2026 12:25

Copilot started reviewing on behalf of karenhes March 25, 2026 12:26 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

jpdefrutos requested changes Apr 16, 2026

View reviewed changes

karenhes and others added 4 commits April 17, 2026 11:30

Update subsequence_classification/views.py

22a3f8e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update subsequence_classification/views.py

898f401

Label exists and already has a colour, this should be preserved Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update subsequence_classification/views.py

95d6a82

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update subsequence_classification/views.py

a6bcbb9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

karenhes commented Apr 17, 2026

View reviewed changes

Comment thread subsequence_classification/static/subsequence_classification/subsequence_classification.js Outdated

karenhes added 2 commits April 17, 2026 13:28

Address reviewer comments.

b967bd8

Merge remote-tracking branch 'origin/feature/textbox-colored-labels' …

7e4bd04

…into feature/textbox-colored-labels

jpdefrutos requested changes Apr 17, 2026

View reviewed changes

Address reviewer comments. Changed color_red to red and so on. string…

5389bc3

…ToColor function now checks whether the generated colour has already been used, and changes it otherwise.

jpdefrutos mentioned this pull request May 21, 2026

bounding box annotation for bronchoscopy videos #21

Merged

		print(f"Custom label: {custom_label}, Created: {created}, Colors: {custom_label_colors.get(custom_label)}")
		#if created:

Conversation

karenhes commented Mar 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

jpdefrutos left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants